Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes failing signup system test on travis #8461

Merged
merged 5 commits into from
Oct 6, 2020
Merged

Fixes failing signup system test on travis #8461

merged 5 commits into from
Oct 6, 2020

Conversation

cesswairimu
Copy link
Collaborator

Fixes #8460 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 6, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented Oct 6, 2020 •
edited
Loading

Codecov Report

Merging #8461 into main will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8461      +/-   ##
==========================================
- Coverage   82.01%   81.89%   -0.12%     
==========================================
  Files         101      101              
  Lines        5899     5899              
==========================================
- Hits         4838     4831       -7     
- Misses       1061     1068       +7
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) ⬇️

@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

Odd, another related now:

 FAIL["test_the_signup_form_is_validated_on_page_reload", #<Minitest::Reporters::Suite:0x0000000007de12f8 @name="SignupFormTest">, 249.792315105]
 test_the_signup_form_is_validated_on_page_reload#SignupFormTest (249.79s)
        expected to find css "#error-message #errorExplanation" but there were no matches
        test/system/signup_form_test.rb:21:in `block in <class:SignupFormTest>'
[1006/150811.883020:WARNING:spdy_session.cc(3352)] Received HEADERS for invalid stream 175

@jywarren jywarren mentioned this pull request Oct 6, 2020
Merged
5 tasks
@jywarren jywarren mentioned this pull request Oct 6, 2020
Merged
@jywarren
Copy link
Member

jywarren commented Oct 6, 2020

This looks perfect. Many thanks for resolving this!!!!

@jywarren jywarren merged commit 367ef50 into main Oct 6, 2020
This was referenced Oct 6, 2020
Closed
Closed
cesswairimu added a commit that referenced this pull request Oct 6, 2020
@cesswairimu
Revert "Fixes failing signup system test on travis (#8461)"
b4a1ecf 
This reverts commit 367ef50.
@cesswairimu cesswairimu mentioned this pull request Oct 6, 2020
Closed
cesswairimu added a commit that referenced this pull request Oct 6, 2020
@cesswairimu
Fixes failing signup system test on travis (#8461)
c150b5b 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
cesswairimu added a commit that referenced this pull request Oct 6, 2020
@cesswairimu
Revert "Fixes failing signup system test on travis (#8461)"
e6a282f 
This reverts commit 367ef50.
@cesswairimu cesswairimu mentioned this pull request Oct 6, 2020
Merged
5 tasks
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
@cesswairimu @shubhangikori
Fixes failing signup system test on travis (publiclab#8461)
684c561 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
@cesswairimu @alvesitalo
Fixes failing signup system test on travis (publiclab#8461)
73b43b1 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
@cesswairimu
Fixes failing signup system test on travis (publiclab#8461)
be38e61 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
@cesswairimu @manchere
Fixes failing signup system test on travis (publiclab#8461)
2d087b8 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
@cesswairimu @lagunasmel
Fixes failing signup system test on travis (publiclab#8461)
b9637af 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@cesswairimu @reginaalyssa
Fixes failing signup system test on travis (publiclab#8461)
14c9cb5 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
@cesswairimu
Fixes failing signup system test on travis (publiclab#8461)
f573bf1 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@cesswairimu @billymoroney1
Fixes failing signup system test on travis (publiclab#8461)
0e9a3ec 
* assert correct request url

* check validation text

* check the flash includes spam detection exception

* assert full spam detection text

* remove assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reverting signup validation PR related to failing test
2 participants
@cesswairimu @jywarren